Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Tethys Update (Foundation 6.2) #740

Closed
wants to merge 6 commits into from
Closed

Tethys Update (Foundation 6.2) #740

wants to merge 6 commits into from

Conversation

colin-marshall
Copy link
Collaborator

Needs testing. Includes:

  • Babel processing in the JavaScript build pipeline (no polyfills used, everything is backwards compatible with ES5)
  • Updated FontAwesome to 4.5
  • Updated Motion-UI to 1.2.2
  • Modified settings file for Foundation 6.2

Of note:

  • I had to update the navigation dropdown arrow removal. I had to place the rule outside of the .top-bar class in _navigation.scss in order to preserve submenu/second level dropdown arrows. This may effect dropdown menus outside of the navigation, so an alternate solution might be necessary.
  • The top bar looks funny in the Kitchen Sink
    • Input box & button are not vertically centered
    • Site Title font is black on black background
  • Kitchen Sink needs the new components: Range Input, Progress Element, & Meter Element

@olefredrik
Copy link
Owner

Hi, @colin-marshall ! Great work, thanks!

A few comments

  1. I got this error on npm install
[14:56:16] Starting 'lint'...

events.js:141
      throw er; // Unhandled 'error' event
      ^
ReferenceError: Unknown plugin "transform-es2015-arrow-functions" specified in "/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/.babelrc" at 0, attempted to resolve relative to "/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress"
    at /Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/options/option-manager.js:206:17
    at Array.map (native)
    at Function.normalisePlugins (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/options/option-manager.js:182:20)
    at OptionManager.mergeOptions (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/options/option-manager.js:298:36)
    at OptionManager.addConfig (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/options/option-manager.js:234:10)
    at OptionManager.findConfigs (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/options/option-manager.js:434:16)
    at OptionManager.init (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/options/option-manager.js:482:12)
    at File.initOptions (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/index.js:211:75)
    at new File (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/file/index.js:129:22)
    at Pipeline.transform (/Users/olelie/MAMP/htdocs/FoundationPress/source/wp-content/themes/FoundationPress/node_modules/babel-core/lib/transformation/pipeline.js:48:16)

I added the following devDependencies to package.json and got rid of the error:

    "babel-plugin-transform-es2015-modules-commonjs": "^6.3.13",
    "babel-plugin-transform-es2015-arrow-functions": "^6.3.13",
    "babel-plugin-transform-es2015-block-scoped-functions": "^6.3.13",
    "babel-plugin-transform-es2015-block-scoping": "^6.4.0",
    "babel-plugin-transform-es2015-classes": "^6.3.15",
    "babel-plugin-transform-es2015-destructuring": "^6.3.15",
    "babel-plugin-transform-es2015-parameters": "^6.3.26",
    "babel-plugin-transform-es2015-shorthand-properties": "^6.5.0",
    "babel-plugin-transform-es2015-spread": "^6.4.0",
    "babel-plugin-transform-es2015-template-literals": "^6.3.13",
    "babel-register": "^6.5.2"

  1. We should consider adding jQuery to the dependency list in bower.json, to avoid prompt on which jQuery version to use during npm install. The CDN hosted jQuery version in library/eneuque-scripts.php should also be updated to 2.2.0.

  2. On npm install/build/watch the following warning is displayed
    WARNING: Rename $grid-column-responsive-gutter to $grid-column-gutter to remove this warning. on line 41 of assets/components/foundation-sites/scss/grid/_grid.scss

This can be fixed by changing $grid-column-responsive-gutter to $grid-column-gutter on line 91 in assets/scss/global/_settings.scss

  1. The mobile menu toggle (aka the hamburger icon) is gone. If we put @include foundation-menu-icon;
    in the foundation.scss file, the burger is back.

Don't know if I should commit the fixes to your pull request (or if that is even possible), or if you should do it? When this PR is merged, I can make a new pull request with the necessary adjustments in the kitchen-sink template.

Solid work, Colin! Really appreciate your commitment and effort! :)

@olefredrik olefredrik mentioned this pull request Mar 2, 2016
Closed
@olefredrik
Copy link
Owner

Couldn't find out how to update this PR with my changes, so I created a new one: #742

Thanks again.

@olefredrik olefredrik closed this Mar 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-marshall @olefredrik @Aetles